launcher/CMake: Add symlink to bin on Linux#581
Draft
joebonrichie wants to merge 1 commit intoopenmoh:mainfrom
Draft
launcher/CMake: Add symlink to bin on Linux#581joebonrichie wants to merge 1 commit intoopenmoh:mainfrom
joebonrichie wants to merge 1 commit intoopenmoh:mainfrom
Conversation
Contributor
Author
|
Should resolve the last issue of #526 |
joebonrichie
had a problem deploying
to
testing
GitHub Actions
Failure
So it's available in $PATH Since CMAKE_INSTALL_BINDIR is overridden to CMAKE_INSTALL_LIBDIR on Linux, hardcode the bin directory as it's universal. We also have to do a weird dance of a temporary .link file in the build dir to get this to work correctly for distribution packaging purposes. See https://github.com/zeek/cmake/blob/master/InstallSymlink.cmake#L24
joebonrichie
force-pushed
the
launchers-in-path-linux
branch
from
8f0e1c1 to
60cdd2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it's available in $PATH
Since CMAKE_INSTALL_BINDIR is overridden to CMAKE_INSTALL_LIBDIR on Linux, hardcode the bin directory as it's universal.
We also have to do a weird dance of a temporary .link file in the build dir to get this to work correctly for distribution packaging purposes. See https://github.com/zeek/cmake/blob/master/InstallSymlink.cmake#L24